Skip to content

BUGFIX: fix support for stateful React components with TypeScript by making props mandatory #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
markusguenther merged 1 commit into from
Aug 25, 2018
Merged

BUGFIX: fix support for stateful React components with TypeScript by making props mandatory #33

markusguenther merged 1 commit into from
Aug 25, 2018

Conversation

@dimaip
Copy link

@dimaip dimaip commented Aug 24, 2018 •
edited
Loading

WARNING: I'm a TS n00b, this is my first day with it.

Take a simple class-based react component and try to wrap it with themr:

import React from 'react';
import {themr} from '@friendsofreactjs/react-css-themr';

interface LabelProps {
    [x: string]: any;
}

class Label extends React.Component<LabelProps> {
    render() {
        return <div/>;
    }
}

themr('123', {})(Label);

You'd get an error:

[ts]
Argument of type 'typeof Label' is not assignable to parameter of type '(new (props?: LabelProps | undefined, context?: any) => Component<LabelProps, {}, any>) | StatelessComponent<LabelProps>'.
  Type 'typeof Label' is not assignable to type 'StatelessComponent<LabelProps>'.
    Type 'typeof Label' provides no match for the signature '(props: LabelProps & { children?: ReactNode; }, context?: any): ReactElement<any> | null'.

This happens because themr defines props as optional where as @type/react defines it as mandatory: new (props: P, context?: any): Component<P, S>; .

This was referenced Aug 24, 2018
Merged
Open
@markusguenther markusguenther merged commit 9ab46f6 into FriendsOfReactJS:develop Aug 25, 2018
@markusguenther
Copy link
Member

markusguenther commented Aug 25, 2018

Thanks @dimaip for your contribution :)

@markusguenther
Copy link
Member

markusguenther commented Aug 25, 2018

🎉 This PR is included in version 3.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dimaip @markusguenther